On 03/11/2016 01:07 PM, Paolo Bonzini wrote:
> 
> 
> On 11/03/2016 12:44, Christian Borntraeger wrote:
>>> -    s->tick_offset_vmstate = s->tick_offset + delta / get_ticks_per_sec();
>>>> +    s->tick_offset_vmstate = s->tick_offset + delta / 
>>>> NANOSECONDS_PER_SECOND;
>> [...]
>>
>> While technically correct, I do not like these changes. The interfaces 
>> expect "ticks",
>> and the fact that this happens to be a nanosecond does not help regarding 
>> readability.
> 
> Actually, I think usage of "tick" in this file is just for historical
> reasons.


So in essence the patch is ok and we should try to get rid of the "tick" word 
in future
patches?

Christian


Reply via email to