On 08.11.22 13:37, Kevin Wolf wrote:
drained_end_counter is unused now, nobody changes its value any more. It
can be removed.

In cases where we had two almost identical functions that only differed
in whether the caller passes drained_end_counter, or whether they would
poll for a local drained_end_counter to reach 0, these become a single
function.

Signed-off-by: Kevin Wolf <kw...@redhat.com>
---
  include/block/block-io.h         | 15 -----
  include/block/block_int-common.h |  6 +-
  block.c                          |  5 +-
  block/block-backend.c            |  4 +-
  block/io.c                       | 97 ++++++++------------------------
  blockjob.c                       |  2 +-
  6 files changed, 30 insertions(+), 99 deletions(-)

The comments on bdrv_drained_end() and bdrv_parent_drained_end_single() in include/block/block-io.h still say that they poll some AioContext “which may result in a graph change”.  That’s no longer the case, though, so those paragraphs should be dropped, I think.

Apart from that, looks good.

Hanna


Reply via email to