On 11/23/22 14:45, Kevin Wolf wrote:
I think this means that if we clean up everything, in the end we'll have coroutine_wrapper and coroutine_wrapper_bdrv (the fourth version not in the above list, but that Paolo mentioned we may want to have).
Yes, I agree.
The only thing I'm unsure about is whether coroutine_wrapper_bdrv is descriptive enough as a name or whether it should be something more explicit like coroutine_wrapper_bdrv_graph_locked.
That's already long and becomes longer if you add "mixed", but perhaps co_wrapper_{mixed_,}{bdrv_graph_rdlock,} would be okay?
In other words: generated_co_wrapper_simple -> co_wrapper generated_co_wrapper -> co_wrapper_mixed generated_co_wrapper_bdrv -> co_wrapper_mixed_bdrv_graph_rdlock ? Paolo
