"Michael S. Tsirkin" <m...@redhat.com> writes:
> On Wed, Nov 30, 2022 at 10:25:58AM +0000, Alex Bennée wrote: >> >> Raphael Norwitz <raphael.norw...@nutanix.com> writes: >> >> >> On Nov 29, 2022, at 12:30 AM, Michael S. Tsirkin <m...@redhat.com> wrote: >> >> >> >> On Tue, Nov 29, 2022 at 05:18:58AM +0000, Raphael Norwitz wrote: >> >>>> On Nov 28, 2022, at 11:41 AM, Alex Bennée <alex.ben...@linaro.org> >> >>>> wrote: >> >>>> >> >>>> ..and use for both virtio-user-blk and virtio-user-gpio. This avoids >> >>>> the circular close by deferring shutdown due to disconnection until a >> >>>> later point. virtio-user-blk already had this mechanism in place so >> >>> >> >>> The mechanism was originally copied from virtio-net so we should >> >>> probably fix it there too. AFAICT calling vhost_user_async_close() >> >>> should work in net_vhost_user_event(). >> >>> >> >>> Otherwise the code looks good modulo a few nits. Happy to see >> >>> the duplicated logic is being generalized. >> >> >> >> If you do, separate patch pls and does not have to block this series. >> > >> > If the series is urgent my comments can be addressed later. >> >> On the surface it looks similar but the vhost-net code doesn't deal in >> DeviceState opaques and also has invented a s->watch variable for >> manually removing gio sources. I'm not sure I'm confident I can >> re-factor this code and not break something so close to release. > > OK, that's fair. See 20221130112439.2527228-1-alex.ben...@linaro.org for the v4 series. -- Alex Bennée