Avihai Horon <avih...@nvidia.com> wrote: > On 07/02/2023 2:56, Juan Quintela wrote: >> External email: Use caution opening links or attachments >> >> >> We split the function into to: >> >> - state_pending_estimate: We estimate the remaining state size without >> stopping the machine. >> >> - state pending_exact: We calculate the exact amount of remaining >> state. >> >> The only "device" that implements different functions for _estimate() >> and _exact() is ram. >> >> Signed-off-by: Juan Quintela <quint...@redhat.com> >> Reviewed-by: Dr. David Alan Gilbert <dgilb...@redhat.com> > > I only noticed it now while rebasing my series on top of yours. > > I think the exact and estimate callbacks got mixed up here: we call > .state_pending_estimate() in qemu_savevm_state_pending_exact() and > .state_pending_exact() in qemu_savevm_state_pending_estimate(). > Also need to switch the !se->ops->state_pending_exact/estimate checks.
Good catch. Sent a patch to fix it. Thanks a lot.
