Am 13.02.2023 um 11:31 hat Denis V. Lunev geschrieben: > The error generated when the option could not be changed inside > bdrv_reopen_prepare() does not give a clue about problematic > BlockDriverState as we could get very long tree of devices. > > The patch adds node name to the error report in the same way as done > above. > > Signed-off-by: Denis V. Lunev <d...@openvz.org> > CC: Kevin Wolf <kw...@redhat.com> > CC: Hanna Reitz <hre...@redhat.com> > CC: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru>
Truly fascinating how inconsistent error reporting is in bdrv_reopen_prepare(). Some places use the node name, some places device or node name, some places filename and some places nothing. Your choice is as good as any. The only problem I can see with this patch is that qemu-iotests 245 needs an update, too. Kevin
