On Thu, 2023-03-09 at 14:08 -0500, Stefan Hajnoczi wrote:
> The HMP monitor runs in the main loop thread. Calling
> AIO_WAIT_WHILE(qemu_get_aio_context(), ...) from the main loop thread
> is
> equivalent to AIO_WAIT_WHILE_UNLOCKED(NULL, ...) because neither
> unlocks
> the AioContext and the latter's assertion that we're in the main loop
> succeeds.
>
> Reviewed-by: Philippe Mathieu-Daudé <phi...@linaro.org>
> Tested-by: Philippe Mathieu-Daudé <phi...@linaro.org>
> Reviewed-by: Markus Armbruster <arm...@redhat.com>
> Reviewed-by: Kevin Wolf <kw...@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com>
> ---
> monitor/hmp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Wilfred Mallawa <wilfred.mall...@wdc.com>
>
> diff --git a/monitor/hmp.c b/monitor/hmp.c
> index fee410362f..5cab56d355 100644
> --- a/monitor/hmp.c
> +++ b/monitor/hmp.c
> @@ -1167,7 +1167,7 @@ void handle_hmp_command(MonitorHMP *mon, const
> char *cmdline)
> Coroutine *co = qemu_coroutine_create(handle_hmp_command_co,
> &data);
> monitor_set_cur(co, &mon->common);
> aio_co_enter(qemu_get_aio_context(), co);
> - AIO_WAIT_WHILE(qemu_get_aio_context(), !data.done);
> + AIO_WAIT_WHILE_UNLOCKED(NULL, !data.done);
> }
>
> qobject_unref(qdict);
