On 05.04.2016 11:21, Sascha Silbe wrote: > Placing files with predictable or even hard-coded names in /tmp is a > security risk and can prevent or disturb operation on a multi-user > machine. Place them inside the "scratch" directory instead, as we > already do for most other test-related files. > > Signed-off-by: Sascha Silbe <si...@linux.vnet.ibm.com> > Reviewed-by: Bo Tu <t...@linux.vnet.ibm.com> > --- > tests/qemu-iotests/check | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-)
Nice side effect: With this patch it's possible to run multiple
instances of the iotests in parallel (for different formats/protocols)
without them interfering with each other.
Grepping for '/tmp' in the iotests directory yields more occurrences,
however: Many tests set the tmp variable to /tmp/$$. Let's see whether
we can just remove that or have to replace it by "${TEST_DIR}"/$$.
"common.filter" evaluates $tmp, but the single filter that does so is
actually never used any more. Other than that, only "common" evaluates
it, but "common" is sourced by "check". Thus I think those tests setting
$tmp is superfluous and dropping it should be fine.
For this patch:
Reviewed-by: Max Reitz <mre...@redhat.com>
You decide whether you want to drop the tmp=/tmp/$$ lines in the tests
in a dedicated (follow-up) patch or include it here.
Max
signature.asc
Description: OpenPGP digital signature
