Am 03.05.2023 um 16:53 hat Juan Quintela geschrieben: > Kevin Wolf <kw...@redhat.com> wrote: > > Am 27.04.2023 um 17:22 hat Juan Quintela geschrieben: > >> Notice that we changed the test of ->has_block_bitmap_mapping > >> for the test that block_bitmap_mapping is not NULL. > >> > >> Signed-off-by: Juan Quintela <quint...@redhat.com> > >> Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> > >> > >> --- > >> > >> Make it return const (vladimir) > > > > (I don't think this part was actually meant for the commit message) > > > > This commit broke qemu-iotests 300 on master. Please have a look. > > > > Kevin > > grrr > > selfNack > > Just wondering, make check don't run this? > > I run "make check" before I sent the pull request.
"make check" only runs a subset of iotests because it would take too long otherwise (especially in the context of CI - it wasn't me who made this decision). It comes at the cost that sometimes we catch problems only after merging the patch to git master when a block developer first runs the full set of tests. So I wouldn't blame your testing, it's just something that happens, and when it happens we need to look after it. Kevin
