On Tue, Jul 25, 2023 at 02:03:37PM -0400, John Snow wrote: > By using a socketpair for all of the sockets managed by the VM class and > its extensions, we don't need the sock_dir argument anymore, so remove > it. > > We only added this argument so that we could specify a second, shorter > temporary directory for cases where the temp/log dirs were "too long" as > a socket name on macOS. We don't need it for this class now. In one > case, avocado testing takes over responsibility for creating an > appropriate sockdir. > > Signed-off-by: John Snow <js...@redhat.com> > --- > python/qemu/machine/machine.py | 18 ------------------ > python/qemu/machine/qtest.py | 5 +---- > tests/avocado/acpi-bits.py | 5 +---- > tests/avocado/avocado_qemu/__init__.py | 2 +- > tests/avocado/machine_aspeed.py | 5 ++++- > tests/qemu-iotests/iotests.py | 2 +- > tests/qemu-iotests/tests/copy-before-write | 3 +-- > 7 files changed, 9 insertions(+), 31 deletions(-)
Reviewed-by: Daniel P. Berrangé <berra...@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|