Kevin Wolf <kw...@redhat.com> writes: > Am 22.04.2016 um 12:24 hat Daniel P. Berrange geschrieben: >> The iSCSI block driver has ability to lookup various options, in >> particular authentication info, specified by the separate -iscsi >> argument. It currently uses the iSCSI IQN as the ID value for this >> lookup, however, this does not work for common iSCSI IQNs as they >> contain characters such as ':' which are invalid for use as IDs. >> >> This adds an optional 'iscsi-id' parameter to the iSCSI block >> driver to allow an explicit ID string to be used to reference >> the -iscsi arg. For example >> >> $QEMU \ >> -iscsi id=my_initiator,user=fred,password-secret=sec0 \ >> -drive driver=iscsi,iscsi-id=my_initiator,file=iscsi://somehost/iqn/1 >> >> Signed-off-by: Daniel P. Berrange <berra...@redhat.com>
This patch is cleaner and safer than "block: convert iscsi target to a valid ID for -iscsi arg lookup". > I would consider this a new feature rather than a fix appropriate for > -rc4. I'd be willing to spin this as a fix for a design bug, but I agree with Kevin, it missed the boat. I might have supported it up until rc1 or so.