In preparation of raising -Wimplicit-fallthrough to 5, replace all fall-through comments with the fallthrough attribute pseudo-keyword.
Signed-off-by: Emmanouil Pitsidianakis <manos.pitsidiana...@linaro.org> --- hw/char/nrf51_uart.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/char/nrf51_uart.c b/hw/char/nrf51_uart.c index dfe2276d71..3e2b35c7ad 100644 --- a/hw/char/nrf51_uart.c +++ b/hw/char/nrf51_uart.c @@ -113,79 +113,79 @@ static void uart_cancel_transmit(NRF51UARTState *s) static void uart_write(void *opaque, hwaddr addr, uint64_t value, unsigned int size) { NRF51UARTState *s = NRF51_UART(opaque); trace_nrf51_uart_write(addr, value, size); if (!s->enabled && (addr != A_UART_ENABLE)) { return; } switch (addr) { case A_UART_TXD: if (!s->pending_tx_byte && s->tx_started) { s->reg[R_UART_TXD] = value; s->pending_tx_byte = true; uart_transmit(NULL, G_IO_OUT, s); } break; case A_UART_INTEN: s->reg[R_UART_INTEN] = value; break; case A_UART_INTENSET: s->reg[R_UART_INTEN] |= value; break; case A_UART_INTENCLR: s->reg[R_UART_INTEN] &= ~value; break; case A_UART_TXDRDY ... A_UART_RXTO: s->reg[addr / 4] = value; break; case A_UART_ERRORSRC: s->reg[addr / 4] &= ~value; break; case A_UART_RXD: break; case A_UART_RXDRDY: if (value == 0) { s->reg[R_UART_RXDRDY] = 0; } break; case A_UART_STARTTX: if (value == 1) { s->tx_started = true; } break; case A_UART_STARTRX: if (value == 1) { s->rx_started = true; } break; case A_UART_ENABLE: if (value) { if (value == 4) { s->enabled = true; } break; } s->enabled = false; value = 1; - /* fall through */ + fallthrough; case A_UART_SUSPEND: case A_UART_STOPTX: if (value == 1) { s->tx_started = false; } - /* fall through */ + fallthrough; case A_UART_STOPRX: if (addr != A_UART_STOPTX && value == 1) { s->rx_started = false; s->reg[R_UART_RXTO] = 1; } break; default: s->reg[addr / 4] = value; break; } nrf51_uart_update_irq(s); } -- 2.39.2