Re: [PATCH v5 5/6] hw/virtio: add vhost-user-snd and virtio-snd-pci devices

[Manos Pitsidianakis]

On Fri, 20 Oct 2023 12:02, "Michael S. Tsirkin" <m...@redhat.com> wrote:

On Fri, Oct 20, 2023 at 09:16:03AM +0100, Alex Bennée wrote:

Viresh Kumar <viresh.ku...@linaro.org> writes:

> On 19-10-23, 10:56, Alex Bennée wrote:
>> From: Manos Pitsidianakis <manos.pitsidiana...@linaro.org>

>> >> Tested with rust-vmm vhost-user-sound daemon: >> >> RUST_LOG=trace cargo run --bin vhost-user-sound -- --socket /tmp/snd.sock --backend null >> >> Invocation: >> >> qemu-system-x86_64 \

>>             -qmp unix:./qmp-sock,server,wait=off  \
>>             -m 4096 \
>>             -numa node,memdev=mem \
>>             -object 
memory-backend-file,id=mem,size=4G,mem-path=/dev/shm,share=on \
>>             -D qemu.log \
>>             -d guest_errors,trace:\*snd\*,trace:\*sound\*,trace:\*vhost\* \
>>             -chardev socket,id=vsnd,path=/tmp/snd.sock \
>>             -device vhost-user-snd-pci,chardev=vsnd,id=snd \
>>             /path/to/disk

>> >> [AJB: imported from https://github.com/epilys/qemu-virtio-snd/commit/54ae1cdd15fef2d88e9e387a175f099a38c636f4.patch] >> >> Signed-off-by: Alex Bennée <alex.ben...@linaro.org>

>
> Missing SOB from Manos ?

oops, guess I need a respin then ;-)

Just ask Manos to send his S.O.B in a reply.

Signed-off-by: Manos Pitsidianakis <manos.pitsidiana...@linaro.org>