On 05.02.24 18:26, Stefan Hajnoczi wrote:
It is not possible to instantiate a virtio-blk device with 0 virtqueues. The following check is located in ->realize():if (!conf->num_queues) { error_setg(errp, "num-queues property must be larger than 0"); return; } Later on we access s->vq_aio_context[0] under the assumption that there is as least one virtqueue. Hanna Czenczek<hre...@redhat.com> noted that it would help to show that the array index is already valid. Add an assertion to document that s->vq_aio_context[0] is always safe...and catch future code changes that break this assumption. Suggested-by: Hanna Czenczek<hre...@redhat.com> Signed-off-by: Stefan Hajnoczi<stefa...@redhat.com> --- hw/block/virtio-blk.c | 1 + 1 file changed, 1 insertion(+)
Reviewed-by: Hanna Czenczek <hre...@redhat.com>
