26.02.2024 17:34, Daniel P. Berrangé wrote:
On Thu, Feb 22, 2024 at 12:15:47AM +0300, Michael Tokarev wrote:
For the global help there's an extra '\n' after 'Usage'. It would be
good go be consistent in this between global and per-command help.
$ ./build/qemu-img --help
qemu-img version 8.2.50 (v8.2.0-1677-g81b20f4b55)
Copyright (c) 2003-2023 Fabrice Bellard and the QEMU Project developers
QEMU disk image utility. Usage:
qemu-img [standard options] COMMAND [--help | command options]
...snip...
vs
$ ./build/qemu-img info --help
Display information about image. Usage:
qemu-img info [-f FMT | --image-opts] [-b] [-U] [--object OBJDEF]
[--output human|json] FILENAME
...snip...
I wonder if we should repeat '[standard options]' for the
per-command help too ?
Yes, this can be done. I remember you prefer less dense output so
let it be the new line in there.
+"\n"
+"Arguments:\n"
In the global help you called it 'Standard options', so for
consistency lets use 'Options:' here too.
Nope. Because in global help it's really options (-foo), while
here, it is options and non-optional arguments too, ie, *all*
arguments, not just options.
/mjt
