On Thu, Mar 21, 2024 at 4:57 PM Jonah Palmer <jonah.pal...@oracle.com> wrote: > > Add support for the VIRTIO_F_IN_ORDER feature across a variety of vhost > devices. > > The inclusion of VIRTIO_F_IN_ORDER in the feature bits arrays for these > devices ensures that the backend is capable of offering and providing > support for this feature, and that it can be disabled if the backend > does not support it. >
Acked-by: Eugenio Pérez <epere...@redhat.com> Thanks! > Signed-off-by: Jonah Palmer <jonah.pal...@oracle.com> > --- > hw/block/vhost-user-blk.c | 1 + > hw/net/vhost_net.c | 2 ++ > hw/scsi/vhost-scsi.c | 1 + > hw/scsi/vhost-user-scsi.c | 1 + > hw/virtio/vhost-user-fs.c | 1 + > hw/virtio/vhost-user-vsock.c | 1 + > net/vhost-vdpa.c | 1 + > 7 files changed, 8 insertions(+) > > diff --git a/hw/block/vhost-user-blk.c b/hw/block/vhost-user-blk.c > index 6a856ad51a..d176ed857e 100644 > --- a/hw/block/vhost-user-blk.c > +++ b/hw/block/vhost-user-blk.c > @@ -51,6 +51,7 @@ static const int user_feature_bits[] = { > VIRTIO_F_RING_PACKED, > VIRTIO_F_IOMMU_PLATFORM, > VIRTIO_F_RING_RESET, > + VIRTIO_F_IN_ORDER, > VHOST_INVALID_FEATURE_BIT > }; > > diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c > index e8e1661646..33d1d4b9d3 100644 > --- a/hw/net/vhost_net.c > +++ b/hw/net/vhost_net.c > @@ -48,6 +48,7 @@ static const int kernel_feature_bits[] = { > VIRTIO_F_IOMMU_PLATFORM, > VIRTIO_F_RING_PACKED, > VIRTIO_F_RING_RESET, > + VIRTIO_F_IN_ORDER, > VIRTIO_NET_F_HASH_REPORT, > VHOST_INVALID_FEATURE_BIT > }; > @@ -76,6 +77,7 @@ static const int user_feature_bits[] = { > VIRTIO_F_IOMMU_PLATFORM, > VIRTIO_F_RING_PACKED, > VIRTIO_F_RING_RESET, > + VIRTIO_F_IN_ORDER, > VIRTIO_NET_F_RSS, > VIRTIO_NET_F_HASH_REPORT, > VIRTIO_NET_F_GUEST_USO4, > diff --git a/hw/scsi/vhost-scsi.c b/hw/scsi/vhost-scsi.c > index ae26bc19a4..40e7630191 100644 > --- a/hw/scsi/vhost-scsi.c > +++ b/hw/scsi/vhost-scsi.c > @@ -38,6 +38,7 @@ static const int kernel_feature_bits[] = { > VIRTIO_RING_F_EVENT_IDX, > VIRTIO_SCSI_F_HOTPLUG, > VIRTIO_F_RING_RESET, > + VIRTIO_F_IN_ORDER, > VHOST_INVALID_FEATURE_BIT > }; > > diff --git a/hw/scsi/vhost-user-scsi.c b/hw/scsi/vhost-user-scsi.c > index a63b1f4948..1d59951ab7 100644 > --- a/hw/scsi/vhost-user-scsi.c > +++ b/hw/scsi/vhost-user-scsi.c > @@ -36,6 +36,7 @@ static const int user_feature_bits[] = { > VIRTIO_RING_F_EVENT_IDX, > VIRTIO_SCSI_F_HOTPLUG, > VIRTIO_F_RING_RESET, > + VIRTIO_F_IN_ORDER, > VHOST_INVALID_FEATURE_BIT > }; > > diff --git a/hw/virtio/vhost-user-fs.c b/hw/virtio/vhost-user-fs.c > index cca2cd41be..9243dbb128 100644 > --- a/hw/virtio/vhost-user-fs.c > +++ b/hw/virtio/vhost-user-fs.c > @@ -33,6 +33,7 @@ static const int user_feature_bits[] = { > VIRTIO_F_RING_PACKED, > VIRTIO_F_IOMMU_PLATFORM, > VIRTIO_F_RING_RESET, > + VIRTIO_F_IN_ORDER, > > VHOST_INVALID_FEATURE_BIT > }; > diff --git a/hw/virtio/vhost-user-vsock.c b/hw/virtio/vhost-user-vsock.c > index 9431b9792c..cc7e4e47b4 100644 > --- a/hw/virtio/vhost-user-vsock.c > +++ b/hw/virtio/vhost-user-vsock.c > @@ -21,6 +21,7 @@ static const int user_feature_bits[] = { > VIRTIO_RING_F_INDIRECT_DESC, > VIRTIO_RING_F_EVENT_IDX, > VIRTIO_F_NOTIFY_ON_EMPTY, > + VIRTIO_F_IN_ORDER, > VHOST_INVALID_FEATURE_BIT > }; > > diff --git a/net/vhost-vdpa.c b/net/vhost-vdpa.c > index 85e73dd6a7..ed3185acfa 100644 > --- a/net/vhost-vdpa.c > +++ b/net/vhost-vdpa.c > @@ -62,6 +62,7 @@ const int vdpa_feature_bits[] = { > VIRTIO_F_RING_PACKED, > VIRTIO_F_RING_RESET, > VIRTIO_F_VERSION_1, > + VIRTIO_F_IN_ORDER, > VIRTIO_NET_F_CSUM, > VIRTIO_NET_F_CTRL_GUEST_OFFLOADS, > VIRTIO_NET_F_CTRL_MAC_ADDR, > -- > 2.39.3 >