Saif Abrar <saif.ab...@linux.vnet.ibm.com> writes: > Add CLI options for user specified > - PCI vendor, device, subsystem vendor and subsystem IDs > - IEEE-OUI ID > > e.g. PCI IDs to be specified as follows: > -device > nvme,id_vendor=0xABCD,id_device=0xA0B0,id_subsys_vendor=0xEF00,id_subsys=0xEF01 > > IEEE-OUI ID (Identify Controller bytes 75:73) is to be > specified in LE format. > (e.g. ieee_oui=0xABCDEF => Byte[73]=0xEF, Byte[74]=0xCD, Byte[75]=0xAB). > > Signed-off-by: Saif Abrar <saif.ab...@linux.vnet.ibm.com>
[...] > diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c > index 127c3d2383..35aeb48e0b 100644 > --- a/hw/nvme/ctrl.c > +++ b/hw/nvme/ctrl.c [...] > @@ -8451,6 +8480,13 @@ static Property nvme_props[] = { > params.sriov_max_vq_per_vf, 0), > DEFINE_PROP_BOOL("msix-exclusive-bar", NvmeCtrl, > params.msix_exclusive_bar, > false), > + DEFINE_PROP_UINT16("id_vendor", NvmeCtrl, params.id_vendor, 0), > + DEFINE_PROP_UINT16("id_device", NvmeCtrl, params.id_device, 0), > + DEFINE_PROP_UINT16("id_subsys_vendor", NvmeCtrl, > + params.id_subsys_vendor, > 0), > + DEFINE_PROP_UINT16("id_subsys", NvmeCtrl, params.id_subsys, 0), > + DEFINE_PROP("ieee_oui", NvmeCtrl, params.ieee_oui, nvme_prop_ieee, > + > uint32_t), > DEFINE_PROP_END_OF_LIST(), > }; You add properties, not CLI options. Properties are accessible via CLI -device, but also via monitor device_add, qom-set, qom-get. Please rephrase your commit message like "Add properties for".