On 05/12/2016 01:47 AM, Daniel P. Berrange wrote: > On Wed, May 11, 2016 at 04:39:42PM -0600, Eric Blake wrote: >> The NBD protocol allows servers to advertise a human-readable >> description alongside an export name during NBD_OPT_LIST. Add >> an option to pass through the user's string to the NBD client. >> >> Doing this also makes it easier to test commit 200650d4, which >> is the client counterpart of receiving the description. >>
>> -@item -x NAME, --export-name=NAME
>> +@item -x, --export-name=@var{name}
>
> Why this change - that reads as saying that '-x' doesn't take any value
> which is wrong IMHO
It's consistent with other options-with-arguments in the same file, such as:
@item -p, --port=@var{port}
@item -o, --offset=@var{offset}
@item -b, --bind=@var{iface}
@item -k, --socket=@var{path}
etc. Basically, we want to use this common escape hatch (see 'ls
--help', for example):
Mandatory arguments to long options are mandatory for short options too.
>> +@item -D, --description=@var{description}
>
> Likewise this suggests -D doesn't take a value
If you don't like it, then we should have a separate patch for the
entire file should switch over to:
@item -D @var{description}, --description=@var{description}
style, where the mandatory option is listed for both option spellings
for every affected option.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
