On 17.05.2016 09:35, Fam Zheng wrote: > Otherwise the error handling we are expceting will be masked by the
*expecting
> preceding image locking check, and is going to be indistinguishable
> because the error messages are all the same.
>
> Signed-off-by: Fam Zheng <f...@redhat.com>
> ---
> tests/qemu-iotests/087 | 6 ++++++
> 1 file changed, 6 insertions(+)
With the spelling error fixed:
Reviewed-by: Max Reitz <mre...@redhat.com>
But maybe it would be easier to just make these test cases use null-co
instead of a qcow2 file.
>
> diff --git a/tests/qemu-iotests/087 b/tests/qemu-iotests/087
> index e7bca37..60bdec5 100755
> --- a/tests/qemu-iotests/087
> +++ b/tests/qemu-iotests/087
> @@ -84,6 +84,7 @@ run_qemu <<EOF
> "options": {
> "driver": "$IMGFMT",
> "id": "disk",
> + "lock-mode": "off",
> "node-name": "test-node",
And maybe you want to move the lock-mode below the node-name here,
because that's where you put it everywhere else in this patch.
Max
> "file": {
> "driver": "file",
> @@ -97,6 +98,7 @@ run_qemu <<EOF
> "options": {
> "driver": "$IMGFMT",
> "id": "disk",
> + "lock-mode": "off",
> "file": {
> "driver": "file",
> "filename": "$TEST_IMG"
> @@ -109,6 +111,7 @@ run_qemu <<EOF
> "options": {
> "driver": "$IMGFMT",
> "id": "test-node",
> + "lock-mode": "off",
> "file": {
> "driver": "file",
> "filename": "$TEST_IMG"
> @@ -122,6 +125,7 @@ run_qemu <<EOF
> "driver": "$IMGFMT",
> "id": "disk2",
> "node-name": "disk",
> + "lock-mode": "off",
> "file": {
> "driver": "file",
> "filename": "$TEST_IMG"
> @@ -135,6 +139,7 @@ run_qemu <<EOF
> "driver": "$IMGFMT",
> "id": "disk2",
> "node-name": "test-node",
> + "lock-mode": "off",
> "file": {
> "driver": "file",
> "filename": "$TEST_IMG"
> @@ -148,6 +153,7 @@ run_qemu <<EOF
> "driver": "$IMGFMT",
> "id": "disk3",
> "node-name": "disk3",
> + "lock-mode": "off",
> "file": {
> "driver": "file",
> "filename": "$TEST_IMG"
>
signature.asc
Description: OpenPGP digital signature
