On Tue, Jan 13, 2026 at 2:17 AM Thomas Huth <[email protected]> wrote:
>
> On 12/01/2026 21.40, Daniel P. Berrangé wrote:
> > This reverts commit a57cb3e23d5ac918a69d0aab918470ff0b429ff9.
> >
> > The current code now only requires compatibility with Python
> > 3.8 or later.
> >
> > The conditional usage of 'sendmsg' on the async IO socket
> > wrapper will generate a deprecation warning on stderr
> > every time send_fd_scm is used with older Python versions.
> >
> > This has the effect of breaking the QEMU I/O tests when run
> > on Python versions before the 'sendmsg' wrapper was removed.
> >
> > Unconditionally accessing 'sock._sock' ensures we never use
> > the asyncio socket wrapper, and thus never risk triggering
> > deprecation warnings on any Python version
> >
> > Most notably this fixes the QEMU block I/O tests on CentOS
> > Stream9 that use "sendmsg" for FD passing, which otherwise
> > generate deprecation messages breaking the expected output
> > comparison.
> >
> > Signed-off-by: Daniel P. Berrangé <[email protected]>
> > ---
> >   python/qemu/qmp/qmp_client.py | 9 +++------
> >   1 file changed, 3 insertions(+), 6 deletions(-)
>
> Reviewed-by: Thomas Huth <[email protected]>

OK, please merge this with my blessing and I will worry about the
standalone repo afterwards.

Acked-by: John Snow <[email protected]>


Reply via email to