On 23.09.2016 16:32, Kevin Wolf wrote: > This series moves a few more options from flags to the appropriate place. This > doesn't only result in cleaner code, but also allows using these options in > nested node definitions. > > After this series, bds_tree_init() is only a thin wrapper around bdrv_open() > which sets the right defaults for cache modes and the BDRV_O_INACTIVE flag if > necessary. > > Depends on my block branch, specifically Berto's 'read-only' patches. > > v2: > - Patch 3 ('block/qapi: Move 'aio' option to file driver') > Use qapi_enum_parse() instead of parsing manually [Eric] > > - Patch 4 ('block: Parse 'detect-zeroes' in bdrv_open_common()') > Fixed typo in commit message [Eric] > Reuse local detect_zeroes variable instead of querying QemuOpts [Eric] > > Kevin Wolf (7): > block: Drop aio/cache consistency check from qmp_blockdev_add() > block/qapi: Use separate options type for curl driver > block/qapi: Move 'aio' option to file driver > block: Parse 'detect-zeroes' in bdrv_open_common() > block: Use 'detect-zeroes' option for 'blockdev-change-medium' > block: Move 'discard' option to bdrv_open_common() > block: Remove qemu_root_bds_opts > > block.c | 50 ++++++++++++++++++- > block/block-backend.c | 9 ++-- > block/raw-posix.c | 44 ++++++++++------- > block/raw-win32.c | 56 +++++++++++++++++++-- > blockdev.c | 110 > +++-------------------------------------- > include/block/block.h | 1 + > include/sysemu/block-backend.h | 2 +- > qapi/block-core.json | 31 ++++++++---- > tests/qemu-iotests/087 | 4 +- > tests/qemu-iotests/087.out | 2 +- > 10 files changed, 164 insertions(+), 145 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com> It's a bit funny now how blockdev_init() and extract_common_blockdev_options() are actually used by neither blockdev-add nor -blockdev, but only by drive_new() (which happily advertises blockdev_init() to be shared with blockev-add, though). Max
signature.asc
Description: OpenPGP digital signature