On 09/30/2016 09:45 AM, Daniel P. Berrange wrote: > The input_visitor_test_add() method was accepting an instance > of 'TestInputVisitorData' and passing it as the 'user_data' > parameter to test functions. The main 'TestInputVisitorData' > instance that was actually used, was meanwhile being allocated > automatically by the test framework fixture setup. > > The 'user_data' parameter is going to be needed for tests > added in later patches, so getting rid of the current mistaken > usage now allows this. > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > --- > tests/test-qobject-input-visitor.c | 76 > ++++++++++++++++---------------------- > 1 file changed, 32 insertions(+), 44 deletions(-)
Reviewed-by: Eric Blake <ebl...@redhat.com> The improved commit message makes the difference :) -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
