On 09/30/2016 09:45 AM, Daniel P. Berrange wrote: > Instead of requiring all callers to go through the mutli-step > process of turning QemuOpts into a suitable QObject for visiting, > add a new constructor that encapsulates this logic. This will > allow QObjectInputVisitor to be a drop-in replacement for the > existing OptsVisitor with minimal code changes for callers. > > NB, at this point it is only supporting opts syntax which > explicitly matches the QAPI schema structure, so is not yet > a true drop-in replacement for OptsVisitor. The patches that > follow will add the special cases requird for full backwards
s/requird/required/ > compatibility with OptsVisitor. > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > --- > +++ b/include/qemu/option.h > @@ -125,7 +125,7 @@ void qemu_opts_set_defaults(QemuOptsList *list, const > char *params, > int permit_abbrev); > QemuOpts *qemu_opts_from_qdict(QemuOptsList *list, const QDict *qdict, > Error **errp); > -QDict *qemu_opts_to_qdict(QemuOpts *opts, QDict *qdict); > +QDict *qemu_opts_to_qdict(const QemuOpts *opts, QDict *qdict); > void qemu_opts_absorb_qdict(QemuOpts *opts, QDict *qdict, Error **errp); Should the const-correctness of this parameter be hoisted to any earlier patch? But here is fine, as the first place where the compiler requires it. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
