Am 20.10.2016 um 10:06 hat KONRAD Frederic geschrieben: > Hi, > > Le 20/10/2016 à 09:55, Kevin Wolf a écrit : > >This adds a qbus to the floppy controller that should contain the floppy > >drives eventually. At the moment it just exists and is empty. > > > >Signed-off-by: Kevin Wolf <kw...@redhat.com> > >Reviewed-by: John Snow <js...@redhat.com> > >--- > > hw/block/fdc.c | 40 +++++++++++++++++++++++++++++++++++----- > > 1 file changed, 35 insertions(+), 5 deletions(-) > > > >diff --git a/hw/block/fdc.c b/hw/block/fdc.c > >index b79873a..a3afb62 100644 > >--- a/hw/block/fdc.c > >+++ b/hw/block/fdc.c > >@@ -52,6 +52,33 @@ > > } \ > > } while (0) > > > >+ > >+/********************************************************/ > >+/* qdev floppy bus */ > >+ > >+#define TYPE_FLOPPY_BUS "Floppy" > > I don't remember of any TYPE_* starting with a uppercase. Maybe > better using floppy? or floppy-bus?
This patch is mostly modelled after IDE. The block related ones are: include/hw/ide/internal.h:#define TYPE_IDE_BUS "IDE" include/hw/scsi/scsi.h:#define TYPE_SCSI_BUS "SCSI" There are more uppercase ones (even non-acronyms), but I admit that I didn't check for other users but just did what IDE does. Kevin