Am 25.10.2016 um 20:37 hat Eric Blake geschrieben: > On 10/24/2016 09:54 PM, Max Reitz wrote: > > While commit 38bbc0a580f9f10570b1d1b5d3e92f0e6feb2970 is correct in that > > the callback is supposed to return the number of bytes handled; what it > > does not mention is that libcurl will throw an error if the callback did > > not "handle" all of the data passed to it. > > > > Therefore, if the callback receives some data that it cannot handle > > (either because the receive buffer has not been set up yet or because it > > would not fit into the receive buffer) and we have to ignore it, we > > still have to report that the data has been handled. > > > > Obviously, this should not happen normally. But it does happen at least > > for FTP connections where some data (that we do not expect) may be > > generated when the connection is established. > > Just to make sure, we aren't losing data by reporting this value, but > merely letting curl know that our callback has "dealt" with the data, so > that we don't error out, in order to get a second chance at the same > data later on? > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > But given that it undoes 38bbc0a, I'd rather that it gets reviewed by > Matthew and/or tested by Richard.
In that case, I guess we should CC them. (Hereby done.) Kevin
pgpPgZnZE1T__.pgp
Description: PGP signature
