On 10/31/2016 12:51 PM, Ashijeet Acharya wrote: > This patch frees the leaked visitor in nbd_refresh_filename() and uses > visit_free() to fix it. > > Signed-off-by: Ashijeet Acharya <ashijeetacha...@gmail.com> > --- > block/nbd.c | 1 + > 1 file changed, 1 insertion(+)
Would be nice to mention that it was commit 491d6c7 that introduced the leak. Reviewed-by: Eric Blake <ebl...@redhat.com> > > diff --git a/block/nbd.c b/block/nbd.c > index 8ef1438..ff9d01a 100644 > --- a/block/nbd.c > +++ b/block/nbd.c > @@ -545,6 +545,7 @@ static void nbd_refresh_filename(BlockDriverState *bs, > QDict *options) > qdict_put(opts, "tls-creds", qstring_from_str(s->tlscredsid)); > } > > + visit_free(ov); > qdict_flatten(opts); > bs->full_open_options = opts; > } > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
