On Wed, Nov 02, 2016 at 06:55:36PM +0100, Max Reitz wrote: > See patch 3 for the reason why we have actually never supported TFTP at > all (except for very small files (i.e. below 256 kB or so)). > > I would consider this series a bug fix because, well, it doesn't really > change any functionality, and the bug is "We don't support TFTP but we > pretend we do". >
I tend to agree. I'm willing to pull this in through my branch for 2.8, unless there arises some outcry with good reason to keep tftp. > > Alternatives to this approach: > > - Deprecate TFTP first. Wait one version, then drop it. > > We could do this, but I personally don't think it's necessary. We have > done this for host_floppy, but in contrast to host_floppy, TFTP really > has never worked. Thus, I conclude that nobody is actually using it or > has ever used it for real work. > > Still, if you think otherwise, we can still do this, of course. > > > - Don't remove TFTP altogether, but just emit a run-time error like we > do for HTTP servers that do not support range-based requests. > > Seems dirty and not like the real solution to me. Also, we have > removed other block drivers in the past, so I don't think we should > keep TFTP. > Since it is broken by nature, I like your original approach of just removing it. > > Max Reitz (3): > qemu-options: Drop mentions of curl's TFTP support > qapi: Drop curl's TFTP protocol > block/curl: Drop TFTP "support" > > block/curl.c | 20 +------------------- > docs/qmp-commands.txt | 2 +- > qapi/block-core.json | 7 +++---- > qemu-options.hx | 6 +++--- > 4 files changed, 8 insertions(+), 27 deletions(-) A > 3:1 delete to insert ratio, that is an ideal patch series ;-)
