On 12/07/2016 04:08 AM, Kevin Wolf wrote: >> # Since: 2.7 >> ## >> @@ -2148,25 +2205,163 @@ >> 'data': { 'volume': 'str', >> 'path': 'str', >> 'server': ['GlusterServer'], >> - '*debug-level': 'int' } } >> + '*debug': 'int', >> + '*logfile': 'str' } } >> >> So I was right after all - this IS a backwards-incompatible change (and >> NOT something that was introduced only in 2.8) - but I still argue that >> the change is appropriate NOW (but not later) because blockdev-add is >> the only client of this type in QMP, and that command changed >> backwards-incompatibly at the same time. > > I don't completely understand the change anyway. 'debug-level' is the > better name,
Perhaps so, but 2.7 already used 'debug' on the command line, and released libvirt already targets the command line. Changing the command line to accept 'debug-level' in addition to 'debug' is the only way to not break existing libvirt usage. What's more, we have several instances of 'debug' in other spots of blockdev-add; either they should all be consistently named 'debug-level', or none of them; we made the switch to none of them, as it was easier. > and if the command line doesn't agree, change that one or > grudgingly accept both. But I think we can just change the command line, > it's only a debug option. It may only be a debug option, but for good or bad, libvirt is already targetting it by its current spelling of 'debug'. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature