On 01/19/2017 08:30 AM, Peter Lieven wrote: >>> qemu-img: Could not open >>> 'nfs://172.21.200.61/vcore-dev-cdrom/templates/VC_debian8-20170116.qcow2,linux?readahead=131072': >>> Block protocol 'nfs' doesn't support the option 'readahead-size' >>> >>> Please let me know if the below fix would be correct: >> No, this needs to be fixed the other way round: runtime_opts must use >> the names as specified in the schema, and nfs_client_open() must access >> them as such. Without that, blockdev-add can't work (and the command >> line only with the "wrong" old option names from the URL, whereas it >> should be using the same names as the QAPI schema). > > Shouldn't we support both for backwards compatiblity.?
blockdev-add only needs to support the modern naming. But yes, preserving back-compat spelling of the command-line spellings, as well as matching blockdev-add spellings, is desirable. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
