Am 28.02.2017 um 22:27 hat Markus Armbruster geschrieben: > The new command line option -blockdev works like QMP command > blockdev-add. > > The option argument may be given in JSON syntax, exactly as in QMP. > Example usage: > > -blockdev '{"node-name": "foo", "driver": "raw", "file": {"driver": > "file", "filename": "foo.img"} }' > > The JSON argument doesn't exactly blend into the existing option > syntax, so the traditional KEY=VALUE,... syntax is also supported, > using dotted keys to do the nesting: > > -blockdev node-name=foo,driver=raw,file.driver=file,file.filename=foo.img > > This does not yet support lists or downstream extensions, i.e. keys > with __RFQDN_ prefix, but the next few patches will take care of that. > > Note that calling qmp_blockdev_add() (say via qmp_marshal_block_add()) > right away would crash. We need to stash the configuration for later > instead. This is crudely done, and bypasses QemuOpts, even though > storing configuration is what QemuOpts is for. Need to revamp option > infrastructure to support QAPI types like BlockdevOptions. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> > Signed-off-by: Markus Armbruster <arm...@redhat.com>
Double S-o-B? Anyway: Reviewed-by: Kevin Wolf <kw...@redhat.com>