On 31.03.2017 00:12, Max Reitz wrote: > This test has been broken by changing NBD's blockdev-add interface (from > taking a SocketAddress to taking a SocketAddressFlat). This patch makes > it work again. > > Unfortunately, we cannot just flatten all of the addresses because > nbd-server-start still takes a plain SocketAddress. Therefore, we need > both and this is most easily achieved by writing the SocketAddress into > the code and flattening it where necessary. > > Signed-off-by: Max Reitz <mre...@redhat.com> > --- > I can be convinced to squash this into Markus' patch "nbd: Tidy up > blockdev-add interface" which is the reason this test broke. I > personally don't have a strong opinion on the matter other than "We > won't get Markus to send a v4". > --- > tests/qemu-iotests/147 | 25 +++++++++++++++++-------- > 1 file changed, 17 insertions(+), 8 deletions(-)
Squashed into said patch: https://github.com/XanClic/qemu/commit/block^ (on my block branch: https://github.com/XanClic/qemu/commits/block) Max
signature.asc
Description: OpenPGP digital signature