On Wed, 04/26 16:49, Kevin Wolf wrote: > Am 26.04.2017 um 05:34 hat Fam Zheng geschrieben: > > Signed-off-by: Fam Zheng <f...@redhat.com> > > I'll do the actual review of the test case later, but I already have a > question... Can we find a way to accept the expected lock losses on > systems without OFD? I'm using RHEL 7 as my main development OS, so I > wouldn't like having to deal with false positives there.
Split the lock loss cases to a separate case and _not_run? :) > > Hm... And actually, printing a warning will probably invalidate all the > other reference outputs, too. After all, every single invocation of > qemu/qemu-img/qemu-io will print a warning. Maybe that's a bit too much > even for manual users when they can't do anything about it (which is > unlike the format probing warning that you can get rid of by simply > changing your command line). An idea: make locking=on/off/auto, and auto is on iff OFD is usable, otherwise off. When user specifies locking=on but OFD is unusable, we print a warning. Only in this on test case the warning will be printed on RHEL, and it's easy to filter it out. Fam
