On Wed, Jun 21, 2017 at 06:49:02PM -0400, John Snow wrote: [...]
> > * TODO (after feedback from John Snow): > > - Eric Blake suggested to consider documenting incremental backup > > policies as part of the section: "Live disk backup --- > > `drive-backup` and `blockdev-backup`" > > Perhaps it could be mentioned, but hopefully I've covered it in some > sufficient detail in the (now) docs/devel/bitmaps.md file; Yes, that doc is very useful. That was my precise thought. > I'm a little wary of duplicating efforts in this area, I share your wariness. > but you've covered everything *else* in good detail here, so now my > file is the odd one out. > > I will leave this up to you, really. Perhaps it could be paid some lip > service with a link to the other document? Yes, I was thinking of this, too -- just link to the 'bitmaps' document. A quick side question here: Since upstream QEMU is converging onto Sphinx, and rST, hope you mind if I convert docs/devel/bitmaps.md into rST at somepoint, for consistency's sake. I'll file a separate review, anyway for that. In the long term, all / most other documents would also be converted. > The detail in bitmaps.md is a little more verbose than the rest of > this file, so if you include it wholesale it'd dwarf the rest of this > document. > > What do you think? Yes, I fully agree with your suggestion. I will simply link to the detailed document you wrote, which I was thinking of anyhow. Thanks for your comments! -- /kashyap
