On Wed, Jun 28, 2017 at 05:36:54PM +0200, Kevin Wolf wrote:
Am 28.06.2017 um 17:22 hat Manos Pitsidianakis geschrieben:Since we're moving groups to QOM we will need ids for each group. Can objects be anonymous?Hm, that's a good question. But object_new() doesn't take an ID, so I think they can be anonymous. Looking a bit closer, strcut Object doesn't even have a field for the ID. It seems that what the ID really is is the name of a property in a parent object that points to the new object. So as long as you don't want to have another QOM object point to it, there is no such thing as an ID. Anyway, I followed the call chain from throttle_group_register_tgm() and it ends in throttle_group_incref() where we simply have this: tg = g_new0(ThrottleGroup, 1); tg->name = g_strdup(name); Shouldn't this be using something a little more QOMy now?
Yes, like it was mentioned in the QOM patch's thread block/throttle-groups.c should use QOM internally. I will change this for the next revision and also look into anonymity.
signature.asc
Description: PGP signature
