On 07/26/2017 09:10 AM, Peter Maydell wrote: > On 26 July 2017 at 15:02, Eric Blake <ebl...@redhat.com> wrote: >> These days, many programs are including a bug-reporting address, >> or better yet, a link to the project web site, at the tail of >> their --help output. However, we were not very consistent at >> doing so: only qemu-nbd and qemu-qa mentioned anything, with the >> latter pointing to an individual person instead of the project. >>
>> >> +/* Bug reporting information for --help arguments, About dialogs, etc */ >> +#define QEMU_BUGREPORTS \ >> + "See <http://qemu.org/contribute/report-a-bug> for bug reports.\n" \ >> + "More information on the qemu project at <http://qemu.org>" > > QEMU should be all upper case. Will fix. While at it, it looks weird that one sentence ends in '.' but not the other; I omitted it on the second on the chance that it might interfere with terminals that are able to auto-click the link, but in testing, at least Gnome's terminal manages just fine thanks to the <> bracketing. > >> + > > I wonder if we may regret the embedded newline when > we come to handling UI about dialogs. I guess we > can cross that bridge when we come to it (they > may need to special case it anyway if they want > to make the links clicky). ui/cocoa.m appears to be the only UI expression version information in a GUI (which I have no way to test); the GTK window that I get for './x86_64-softmmu/qemu-system-x86_64' didn't have anything in its menubar. Perhaps it should, but I'm not a gui guy, so I'll leave that patch for someone with more experience. Also, I hit this warning: $ ./x86_64-softmmu/qemu-system-x86_64 (qemu-system-x86_64:19518): Gtk-WARNING **: Allocating size to GtkScrollbar 0x556c628be340 without calling gtk_widget_get_preferred_width/height(). How does the code know the size to allocate? (qemu-system-x86_64:19518): Gtk-WARNING **: gtk_widget_size_allocate(): attempt to allocate widget with width -426186808 and height 400 I have no idea where it's coming from (that is, whether it is a bug in the gtk stack of Fedora 26, or whether it is the fault of qemu itself misusing the preferred dance of gtk calls), but again that's something that I would rather leave to a programmer more familiar with gui issues (you can tell I usually test './x86_64-softmmu/qemu-system-x86_64 -nodefaults --nographic -qmp stdio') -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
