On 08/04/2017 09:43 AM, Kevin Wolf wrote: > This option was only added to allow 'null-co://' and 'null-aio://' as > filenames, its value never served any actual purpose and was ignored. > Nevertheless it was accepted as '-drive driver=null,filename=foo'. > > The correct way to enable the protocol prefixes (and that without adding > a useless -drive option) is implementing .bdrv_parse_filename. This is > what this patch does. > > Technically, this is an incompatible change, but the null block driver > is only used for benchmarking, testing and debugging, and an option > without effect isn't likely to be used by anyone anyway, so no bad > effects are to be expected.
Agreed with the analysis. Still, better to get it into 2.10 rather than going yet another release with the option available. > > Reported-by: Markus Armbruster <arm...@redhat.com> > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > block/null.c | 31 ++++++++++++++++++++++++++----- > 1 file changed, 26 insertions(+), 5 deletions(-) > Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
