Re: [Qemu-block] Unchecked blk_getlength() in device models and board code

[Stefan Hajnoczi]

On Fri, Aug 04, 2017 at 04:01:18PM +0200, Markus Armbruster wrote:
> blk_getlength() can fail.  I figure the following need fixing:
> 
> hw/arm/musicpal.c: musicpal_init()

Seems okay:

flash_size = blk_getlength(blk);
if (flash_size != 8*1024*1024 && flash_size != 16*1024*1024 &&
    flash_size != 32*1024*1024) {
    fprintf(stderr, "Invalid flash image size\n");
    exit(1);
}

> hw/block/virtio-blk.c: virtio_blk_update_config()

Will send a fix.

signature.asc
Description: PGP signature