On 08/08/2017 01:32 PM, John Snow wrote: > Name the registers for tracing purposes. > > Signed-off-by: John Snow <js...@redhat.com> > --- > hw/ide/core.c | 88 > +++++++++++++++++++++++++++++++++++++++++------------ > hw/ide/trace-events | 4 +-- > 2 files changed, 70 insertions(+), 22 deletions(-)
> - case 1: > - ide_clear_hob(bus); > + case ATA_IOPORT_WR_FEATURES: > + ide_clear_hob(bus); Cool, fixing tab damage in the process. I did a similar improvement to NBD traces, and it's definitely worth it to have traces include names in addition to numbers. Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
