Re: [Qemu-block] [PATCH v7 5/6] block: add throttle block filter driver

[Manos Pitsidianakis]

On Tue, Aug 22, 2017 at 04:16:26PM +0200, Alberto Garcia wrote:

On Tue 22 Aug 2017 12:15:34 PM CEST, Manos Pitsidianakis wrote:

@@ -548,6 +548,11 @@ void throttle_group_unregister_tgm(ThrottleGroupMember 
*tgm)
     ThrottleGroupMember *token;
     int i;

+    if (!ts) {
+        /* Discard uninitialized tgm */
+        return;
+    }
+

Is this change needed in case throttle_configure_tgm() fails?

Yes, now all errors are before throttle_group_register_tgm(), therefore the unregister part in throttle_close() will not have valid data.

signature.asc
Description: PGP signature