Re: [Qemu-block] [PATCH v9 5/6] block: add throttle block filter driver

[Stefan Hajnoczi]

On Fri, Aug 25, 2017 at 04:20:27PM +0300, Manos Pitsidianakis wrote:
> +static int throttle_configure_tgm(BlockDriverState *bs,
> +                                  ThrottleGroupMember *tgm,
> +                                  QDict *options, Error **errp)
> +{
> +    int ret;
> +    const char *group_name;
> +    Error *local_err = NULL;
> +    QemuOpts *opts = qemu_opts_create(&throttle_opts, NULL, 0, &error_abort);
> +
> +    qemu_opts_absorb_qdict(opts, options, &local_err);
> +    if (local_err) {
> +        error_propagate(errp, local_err);
> +        ret = -EINVAL;
> +        goto fin;
> +    }
> +
> +    group_name = qemu_opt_get(opts, QEMU_OPT_THROTTLE_GROUP_NAME);
> +    if (!group_name) {
> +        error_setg(errp, "Please specify a throttle group.");

error_setg() messages do not end with punctuation:

  error_setg(errp, "Please specify a throttle group");

This is not worth respinning for though.

> +        ret = -EINVAL;
> +        goto fin;
> +    } else if (!throttle_group_exists(group_name)) {
> +        error_setg(errp, "Throttle group '%s' does not exist.", group_name);

Same here.

Anyway:

Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>