Am 25.08.2017 um 15:23 hat Manos Pitsidianakis geschrieben: > With implicit filter nodes on the top of the graph it is not possible to > generate job-ids with the name of the device in block_job_create() > anymore, since the job's bs will not be a child_root. > > Instead we can require that job-id is not NULL in block_job_create(), > and check that a job-id has been set in the callers of > block_job_create() in blockdev.c. It is more consistent to require an > explicit job-id when the device parameter in the job creation command, > eg > > { "execute": "drive-backup", > "arguments": { "device": "drive0", > "sync": "full", > "target": "backup.img" } } > > is not a BlockBackend name, instead of automatically getting it from the > root BS if device is a node name. That information is lost after calling > block_job_create(), so we can do it in its caller instead. > > Signed-off-by: Manos Pitsidianakis <el13...@mail.ntua.gr>
Reviewed-by: Kevin Wolf <kw...@redhat.com>