On 09/25/2017 07:28 AM, Kevin Wolf wrote: > We don't need to make any assumptions about the graph layout above the > top node of the commit operation any more. Remove the use of > bdrv_find_overlay() and related variables from the commit job code. > > bdrv_drop_intermediate() doesn't use the 'active' parameter any more, so > we can just drop it. > > The overlay node was previously added to the block job to get a > BLK_PERM_GRAPH_MOD. We really need to respect those permissions in > bdrv_drop_intermediate() now, but as long as we haven't figured out yet > how BLK_PERM_GRAPH_MOD is actually supposed to work, just leave a TODO > comment there. > > With this change, it is now possible to perform another block job on an > overlay node without conflicts. qemu-iotests 030 is changed accordingly. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > include/block/block.h | 3 +-- > block.c | 6 +++-- > block/commit.c | 62 > ++++++++++++-------------------------------------- > tests/qemu-iotests/030 | 4 ---- > 4 files changed, 20 insertions(+), 55 deletions(-) >
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature