On 10/12/2017 06:15 AM, Vladimir Sementsov-Ogievskiy wrote: > This is a code movement, no changes. >
>> Checking PATCH 11/13: nbd: share some nbd entities to be reused in
>> block/nbd-client.c...
>> ERROR: return of an errno should typically be -ve (return -EPERM)
>> #46: FILE: include/block/nbd.h:206:
>> + return EPERM;
Indeed. We could avoid the false positive by doing:
case ...:
ret = EPERM;
break;
...
return ret;
to hide the positive errno value, but I'm also fine ignoring checkpatch
on this one.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
