On 12/06/2017 08:45 AM, Stefan Hajnoczi wrote: > Currently there is no easy way for iotests to ensure that a BDS is bound > to a particular IOThread. Normally the virtio-blk device calls > blk_set_aio_context() when dataplane is enabled during guest driver > initialization. This never happens in iotests since -machine > accel=qtest means there is no guest activity (including device driver > initialization). > > This patch adds a QMP command to explicitly assign IOThreads in test > cases. See qapi/block-core.json for a description of the command.
The x- prefix is perfect for this. > > Signed-off-by: Stefan Hajnoczi <stefa...@redhat.com> > --- > qapi/block-core.json | 36 ++++++++++++++++++++++++++++++++++++ > blockdev.c | 41 +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 77 insertions(+) > > +## > +# @x-blockdev-set-iothread: > +# > +# Move @node and its children into the @iothread. If @iothread is null then > +# move @node and its children into the main loop. > +# > +# The node must not be attached to a BlockBackend. > +# > +# @node-name: the name of the block driver node > +# > +# @iothread: the name of the IOThread object or null for the main loop > +# > +# Note: this command is experimental and intended for test cases that need > +# control over IOThreads only. I'd place 'only' sooner; it fits better as 'intended only for ...'. As a wording tweak is minor, Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
