On 2018-05-09 18:26, Kevin Wolf wrote: > Instead of having a 'bool ready' in BlockJob, add a function that > derives its value from the job status. > > At the same time, this fixes the behaviour to match what the QAPI > documentation promises for query-block-job: 'true if the job may be > completed'. When the ready flag was introduced in commit ef6dbf1e46e, > the flag never had to be reset to match the description because after > being ready, the jobs would immediately complete and disappear. > > Job transactions and manual job finalisation were introduced only later. > With these changes, jobs may stay around even after having completed > (and they are not ready to be completed a second time), however their > patches forgot to reset the ready flag. > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > --- > include/block/blockjob.h | 5 ----- > include/qemu/job.h | 3 +++ > blockjob.c | 3 +-- > job.c | 22 ++++++++++++++++++++++ > qemu-img.c | 2 +- > tests/test-blockjob.c | 2 +- > 6 files changed, 28 insertions(+), 9 deletions(-)
Reviewed-by: Max Reitz <mre...@redhat.com>
signature.asc
Description: OpenPGP digital signature
