Hi, This series seems to have some coding style problems. See output below for more information:
Type: series Message-id: 20180518132114.4070-1-kw...@redhat.com Subject: [Qemu-devel] [PATCH v2 00/40] Generic background jobs === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu t [tag update] patchew/20180517092513.735-1-kra...@redhat.com -> patchew/20180517092513.735-1-kra...@redhat.com * [new tag] patchew/20180518132114.4070-1-kw...@redhat.com -> patchew/20180518132114.4070-1-kw...@redhat.com Switched to a new branch 'test' be01aa198a qemu-iotests: Test job-* with block jobs 62233b758c iotests: Move qmp_to_opts() to VM 3f946bc442 blockjob: Remove BlockJob.driver cae6373cbd job: Add query-jobs QMP command 9bf0565e0c job: Add lifecycle QMP commands f7363a69b4 job: Add JOB_STATUS_CHANGE QMP event 5a63efe4e4 job: Introduce qapi/job.json 2a5e7375fa job: Move progress fields to Job 2ae08c1d06 job: Add job_transition_to_ready() 9d76be11bd job: Add job_is_ready() 9b51cc2a7e job: Add job_dismiss() 555a61a69f job: Add job_yield() 798978bcb1 block: Cancel job in bdrv_close_all() callers 4dcb71e4e5 job: Move completion and cancellation to Job ffad8fad4b job: Move transactions to Job 0edc41ca48 job: Switch transactions to JobTxn a1073023f2 job: Move job_finish_sync() to Job 6ec521dbdb job: Move .complete callback to Job 9660a731ab job: Add job_drain() 1958d0ac38 job: Convert block_job_cancel_async() to Job dc1a8d70b8 job: Move single job finalisation to Job 4e7a12008f job: Add job_event_*() d973eb6546 blockjob: Split block_job_event_pending() 7d447f8ab3 job: Move BlockJobCreateFlags to Job ffa1c9ad30 job: Replace BlockJob.completed with job_is_completed() 13e426855c job: Move pause/resume functions to Job 0c52ff1b24 job: Add job_sleep_ns() 5ebf3ba66a job: Move coroutine and related code to Job 4e7b469718 job: Move defer_to_main_loop to Job 896fe05128 job: Add Job.aio_context d73a94fde9 job: Move cancelled to Job e386ae83f9 job: Add reference counting 3915da0ada job: Move state transitions to Job e2ea58c7b0 job: Maintain a list of all jobs 717f2e60bf job: Add job_delete() f31f336bca job: Add JobDriver.job_type 048bb87d0a job: Rename BlockJobType into JobType b2707abc22 job: Create Job, JobDriver and job_create() f7c7867229 blockjob: Improve BlockJobInfo.offset/len documentation 7611d0c75f blockjob: Update block-job-pause/resume documentation === OUTPUT BEGIN === Checking PATCH 1/40: blockjob: Update block-job-pause/resume documentation... Checking PATCH 2/40: blockjob: Improve BlockJobInfo.offset/len documentation... Checking PATCH 3/40: job: Create Job, JobDriver and job_create()... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #353: new file mode 100644 total: 0 errors, 1 warnings, 424 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 4/40: job: Rename BlockJobType into JobType... Checking PATCH 5/40: job: Add JobDriver.job_type... Checking PATCH 6/40: job: Add job_delete()... Checking PATCH 7/40: job: Maintain a list of all jobs... Checking PATCH 8/40: job: Move state transitions to Job... ERROR: space prohibited before open square bracket '[' #342: FILE: job.c:38: + /* U: */ [JOB_STATUS_UNDEFINED] = {0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0}, ERROR: space prohibited before open square bracket '[' #343: FILE: job.c:39: + /* C: */ [JOB_STATUS_CREATED] = {0, 0, 1, 0, 0, 0, 0, 0, 1, 0, 1}, ERROR: space prohibited before open square bracket '[' #344: FILE: job.c:40: + /* R: */ [JOB_STATUS_RUNNING] = {0, 0, 0, 1, 1, 0, 1, 0, 1, 0, 0}, ERROR: space prohibited before open square bracket '[' #345: FILE: job.c:41: + /* P: */ [JOB_STATUS_PAUSED] = {0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0}, ERROR: space prohibited before open square bracket '[' #346: FILE: job.c:42: + /* Y: */ [JOB_STATUS_READY] = {0, 0, 0, 0, 0, 1, 1, 0, 1, 0, 0}, ERROR: space prohibited before open square bracket '[' #347: FILE: job.c:43: + /* S: */ [JOB_STATUS_STANDBY] = {0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0}, ERROR: space prohibited before open square bracket '[' #348: FILE: job.c:44: + /* W: */ [JOB_STATUS_WAITING] = {0, 0, 0, 0, 0, 0, 0, 1, 1, 0, 0}, ERROR: space prohibited before open square bracket '[' #349: FILE: job.c:45: + /* D: */ [JOB_STATUS_PENDING] = {0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 0}, ERROR: space prohibited before open square bracket '[' #350: FILE: job.c:46: + /* X: */ [JOB_STATUS_ABORTING] = {0, 0, 0, 0, 0, 0, 0, 0, 1, 1, 0}, ERROR: space prohibited before open square bracket '[' #351: FILE: job.c:47: + /* E: */ [JOB_STATUS_CONCLUDED] = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1}, ERROR: space prohibited before open square bracket '[' #352: FILE: job.c:48: + /* N: */ [JOB_STATUS_NULL] = {0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0}, total: 11 errors, 0 warnings, 528 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 9/40: job: Add reference counting... Checking PATCH 10/40: job: Move cancelled to Job... Checking PATCH 11/40: job: Add Job.aio_context... Checking PATCH 12/40: job: Move defer_to_main_loop to Job... Checking PATCH 13/40: job: Move coroutine and related code to Job... Checking PATCH 14/40: job: Add job_sleep_ns()... Checking PATCH 15/40: job: Move pause/resume functions to Job... Checking PATCH 16/40: job: Replace BlockJob.completed with job_is_completed()... Checking PATCH 17/40: job: Move BlockJobCreateFlags to Job... Checking PATCH 18/40: blockjob: Split block_job_event_pending()... Checking PATCH 19/40: job: Add job_event_*()... Checking PATCH 20/40: job: Move single job finalisation to Job... WARNING: line over 80 characters #508: FILE: include/qemu/job.h:221: + int flags, BlockCompletionFunc *cb, void *opaque, Error **errp); ERROR: "(foo*)" should be "(foo *)" #578: FILE: job.c:462: + block_job_txn_del_job((BlockJob*) job); ERROR: "(foo*)" should be "(foo *)" #659: FILE: job.c:543: + block_job_txn_del_job((BlockJob*) job); total: 2 errors, 1 warnings, 620 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 21/40: job: Convert block_job_cancel_async() to Job... Checking PATCH 22/40: job: Add job_drain()... Checking PATCH 23/40: job: Move .complete callback to Job... Checking PATCH 24/40: job: Move job_finish_sync() to Job... WARNING: line over 80 characters #139: FILE: include/qemu/job.h:399: +int job_finish_sync(Job *job, void (*finish)(Job *, Error **errp), Error **errp); total: 0 errors, 1 warnings, 144 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 25/40: job: Switch transactions to JobTxn... Checking PATCH 26/40: job: Move transactions to Job... Checking PATCH 27/40: job: Move completion and cancellation to Job... Checking PATCH 28/40: block: Cancel job in bdrv_close_all() callers... Checking PATCH 29/40: job: Add job_yield()... Checking PATCH 30/40: job: Add job_dismiss()... Checking PATCH 31/40: job: Add job_is_ready()... Checking PATCH 32/40: job: Add job_transition_to_ready()... Checking PATCH 33/40: job: Move progress fields to Job... Checking PATCH 34/40: job: Introduce qapi/job.json... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #235: new file mode 100644 total: 0 errors, 1 warnings, 294 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 35/40: job: Add JOB_STATUS_CHANGE QMP event... Checking PATCH 36/40: job: Add lifecycle QMP commands... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #37: new file mode 100644 total: 0 errors, 1 warnings, 265 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 37/40: job: Add query-jobs QMP command... Checking PATCH 38/40: blockjob: Remove BlockJob.driver... ERROR: initializer for struct BlockJobDriver should normally be const #21: FILE: blockjob.c:107: + BlockJobDriver *bjdrv = container_of(drv, BlockJobDriver, job_driver); ERROR: initializer for struct BlockJobDriver should normally be const #36: FILE: blockjob.c:121: + BlockJobDriver *bjdrv = container_of(drv, BlockJobDriver, job_driver); total: 2 errors, 0 warnings, 54 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 39/40: iotests: Move qmp_to_opts() to VM... WARNING: line over 80 characters #109: FILE: tests/qemu-iotests/iotests.py:448: + self.assertEqual(self.vm.flatten_qmp_object(json.loads(json_filename[5:])), total: 0 errors, 1 warnings, 83 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 40/40: qemu-iotests: Test job-* with block jobs... WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #13: new file mode 100755 total: 0 errors, 1 warnings, 540 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com