On 05/18/2018 09:20 AM, Kevin Wolf wrote: > + job->auto_finalize = !(flags & JOB_MANUAL_FINALIZE); > + job->auto_dismiss = !(flags & JOB_MANUAL_DISMISS);
Job API might be a good chance to say "No, this is the default behavior for this API." I don't know how possible this is, but could we remove these behavior flags for jobs (but keep them for block jobs), and then any legacy block job creation interfaces we have can enable/disable them as the user requested, and the block job layer itself has hooks that persuade the core job layer to automatically transition without user input, if appropriate. (Unless that happens later?)