On 2018-04-26 18:19, Roman Kagan wrote: > Signed-off-by: Roman Kagan <rka...@virtuozzo.com> > --- > tests/qemu-iotests/056 | 3 +++ > 1 file changed, 3 insertions(+)
TestBeforeWriteNotifier uses blkdebug (and null-co) in its setUp function. Maybe you just want to skip the whole test if blkdebug is disabled. Then again, I'd argue there are block drivers without which running the iotests is a bit pointless. Why not just require blkdebug, null-co/aio, raw, and file for all of them? I think the reason why we added the check for quorum support was because quorum relies on an external library (for hashing), so it isn't trivial to enable. But you can always easily whitelist those drivers above if you want to do testing, so I'm not sure whether it's worth checking their availability in every test that needs them. Max
signature.asc
Description: OpenPGP digital signature