Re: [Qemu-block] [PATCH v3 3/5] qcow2: Introduce an option for sufficient L2 cache for the entire image

[Leonid Bloch]

On 07/25/2018 03:22 PM, Eric Blake wrote: On 07/25/2018 03:26 AM, Kevin Wolf wrote: Only looking at the external interface for now, I wonder whether it would be nicer not to have two mutually exclusive options, but to make l2-cache-size an alternate that can take either an int like before (meaning the number of bytes) or a string/enum (with the only accepted value "full" for now). That does sound interesting. This does, but currently QEMU supports QEMU_OPT_STRING, QEMU_OPT_BOOL, QEMU_OPT_NUMBER, and QEMU_OPT_SIZE. Looks like it will require a more fundamental change to accept an option that can be either a string or a size. Another interesting question is whether 'full' shouldn't keep meaning full throughout the lifetime of the BlockDriverState, i.e. should it keep adapting to the new size when the image size changes? Do we even resize the cache now for image size changes? If we use an enum, we could have two different values depending on whether the chosen cache size remains fixed or also tries to resize when the image grows. Is it even possible to change the virtual disk image size online? Found a problem with my previous patch: the property was not actually set as a proper boolean option. Also, fixing the error output in iotest 103 (thanks Kevin for the catch!). V5 is on the way.