On Wed 26 Sep 2018 12:43:03 PM CEST, Kevin Wolf wrote: >> + /* Update cache sizes */ >> + options = qdict_clone_shallow(bs->options); >> + ret = qcow2_update_options(bs, options, s->flags, errp); >> + if (ret < 0) { >> + goto fail; >> + } > > Isn't options leaked, both in success and error cases?
I'm embarrassed not to have seen that :-! Berto